Skip to content

[PLAT-4707] Throw descriptive error when polling times out #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

amvertex
Copy link
Contributor

Summary

When a job did not complete in the designated time period, we were not throwing a descriptive error message. With this PR, we will now throw an error that explicitly states that the job timed out, specifically this error.

Test Plan

  • Verify polling jobs behaves as expected
  • Verify a descriptive error is thrown when a job times out

Release Notes

None

Possible Regressions

Polling for jobs to finish

Dependencies

None

@amvertex amvertex requested a review from a team as a code owner October 24, 2024 21:45
@amvertex amvertex requested a review from gbiv October 24, 2024 21:45
Copy link

Copy link
Contributor

@jdm717 jdm717 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amvertex amvertex merged commit ad0d6db into master Oct 25, 2024
2 checks passed
@amvertex amvertex deleted the handle_timeouts branch October 25, 2024 15:16
Copy link
Contributor

@gbiv gbiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late but :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants